pavelmachek (![[info]](http://p-stat.livejournal.com/img/userinfo.gif){kind=small} pavelmachek) wrote,@ 2008-03-29 21:29:00 |
|
MAINTAINERS file sucks
So I want to submit a patch to ALSA... and I'd like to know who the maintainer is, and what list should be CCed... So I open MAINTAINERS file in less, and search for ALSA...
...and nothing relevant comes up. Hmm, perhaps someone was clever and title says "ADVANCED LINUX SOUND ARCHITECTURE"?
...nope. Did I get the acronym wrong? No.
...relevant maintainter is listed under "SOUND". (And the list is subscribers-only). There were about 10 proposals to split MAINTAINERS file and put it close to relevant sources, or at least add "Files: " field to MAINTAINERS file. Perhaps it is time to do something like that?
Oh and BTW ALSA sucks. It invents compeletely new abstractions where none are neccessary:
snd_assert? WTF is that? (and notice the ugly "return -EINVAL" parameter). Rest of kernel uses WARN_ON()...
snd_printk()... what is it? Will it print? [answer is yes, and depending on config option, it will print filename and linenumber, too]
snd_printdd()... what is it? Why is it ALSA-specific? Will I see the printout? [answer is no, unless I tweak the config]
If you are a kernel janitor, and want to clean something up, please take a look at ALSA.
So I want to submit a patch to ALSA... and I'd like to know who the maintainer is, and what list should be CCed... So I open MAINTAINERS file in less, and search for ALSA...
...and nothing relevant comes up. Hmm, perhaps someone was clever and title says "ADVANCED LINUX SOUND ARCHITECTURE"?
...nope. Did I get the acronym wrong? No.
...relevant maintainter is listed under "SOUND". (And the list is subscribers-only). There were about 10 proposals to split MAINTAINERS file and put it close to relevant sources, or at least add "Files: " field to MAINTAINERS file. Perhaps it is time to do something like that?
Oh and BTW ALSA sucks. It invents compeletely new abstractions where none are neccessary:
snd_assert(subs->dataurb[i].urb, return -EINVAL);
if (subs->ops.prepare(subs, runtime, subs->dataurb[i].urb) < 0) {
snd_printk(KERN_ERR "cannot prepare datapipe for urb %d\n", i);
goto __error;
}
...
snd_printdd(KERN_INFO "setting usb interface %d:%d\n", fmt->iface, fmt->altsetting);
snd_assert? WTF is that? (and notice the ugly "return -EINVAL" parameter). Rest of kernel uses WARN_ON()...
snd_printk()... what is it? Will it print? [answer is yes, and depending on config option, it will print filename and linenumber, too]
snd_printdd()... what is it? Why is it ALSA-specific? Will I see the printout? [answer is no, unless I tweak the config]
If you are a kernel janitor, and want to clean something up, please take a look at ALSA.
